Onigmo icon indicating copy to clipboard operation
Onigmo copied to clipboard

Add Unicode properties of East Asian Width

Open aycabta opened this issue 6 years ago • 3 comments

This Pull Request adds Unicode properties about East Asian Width. Supports only full name because some aliases are duplicated, such as N.

In Unicode 10.0.0, this adds below:

  • Ambiguous
  • Fullwidth
  • Halfwidth
  • Neutral
  • Narrow
  • Wide

This Pull Request doesn't contain update files because those files depend on https://github.com/k-takata/Onigmo/pull/101.

For reference, Perl's regular expression supports East_Asian_Width: * type Unicode property like General_Category: *.

ref. https://bugs.ruby-lang.org/issues/14618

aycabta avatar Mar 18 '18 10:03 aycabta

Codecov Report

Merging #102 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   82.86%   82.86%           
=======================================
  Files          62       62           
  Lines       12827    12827           
=======================================
  Hits        10629    10629           
  Misses       2198     2198

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b8c3321...ddaaadd. Read the comment docs.

codecov-io avatar Mar 18 '18 10:03 codecov-io

@k-takata How is this?

aycabta avatar May 05 '18 17:05 aycabta

I object this because width information is not useful in real world. For example recently added emojis are specified as "Narrow", but they are expected to be showed as fullwidth on Japanese environment.

nurse avatar Jul 18 '18 08:07 nurse