openstack-resource-controller icon indicating copy to clipboard operation
openstack-resource-controller copied to clipboard

WIP: Discard zero values from resource status

Open mandre opened this issue 8 months ago • 3 comments

Done for the subnet for now, to gather feedback.

For #188

mandre avatar Apr 14 '25 15:04 mandre

Could this cause issues when mutability is implemented? For example I am thinking about the case where you create a resource with a description, and then you remove the description. With this code unchanged, I suppose that the description in Status would remain?

pierreprinetti avatar Apr 14 '25 15:04 pierreprinetti

Could this cause issues when mutability is implemented? For example I am thinking about the case where you create a resource with a description, and then you remove the description. With this code unchanged, I suppose that the description in Status would remain?

In theory, no, because we're using SSA and everything that is not send gets removed from the resulting resource. Of course, we'll have to test it properly (the update testing pattern we've drafted already accounts for this)

mandre avatar Apr 14 '25 16:04 mandre

Failed to assess the semver bump. See logs for details.

github-actions[bot] avatar May 14 '25 11:05 github-actions[bot]

@mandre Can we close #188, or is there any more work to do?

pierreprinetti avatar Oct 02 '25 12:10 pierreprinetti

@mandre Can we close #188, or is there any more work to do?

Can be closed, good call.

mandre avatar Oct 02 '25 13:10 mandre