openstack-resource-controller icon indicating copy to clipboard operation
openstack-resource-controller copied to clipboard

charts: creation of orc and orc-crds

Open spnngl opened this issue 8 months ago • 1 comments

spnngl avatar Apr 11 '25 13:04 spnngl

Thanks for the PR! I'm not too familiar with helm charts and will have to do some reading to properly review your changes, please expect some delay.

mandre avatar Apr 16 '25 06:04 mandre

I would like to get this merged, is there any way I can support you?

simonostendorf avatar Aug 21 '25 09:08 simonostendorf

I just push a maj, we need someone to take care of the helm repo / OCI push in github-actions I think ^^ Maybe one more pair of eye to review too

spnngl avatar Aug 21 '25 13:08 spnngl

I just push a maj, we need someone to take care of the helm repo / OCI push in github-actions I think ^^ Maybe one more pair of eye to review too

I can have a look at the gh actions and helm chart if thats required/possible, I know the syntax very well and use them quite often in different projects.

simonostendorf avatar Aug 21 '25 20:08 simonostendorf

Go for it, we use those charts for months on our capi management cluster. It works well

spnngl avatar Aug 22 '25 06:08 spnngl

This is great to see activity pick up again in this PR. Any help is welcome, and a new pair of eyes will definitely help.

I'm sadly not experienced enough with helm to know the best practices and I'm afraid some of my feedback would go against some of the helm conventions. I count on you to tell me if that's the case.

That said, there are a few things I'd like us to keep in mind:

  • I would like to minimize the cost for the ORC maintainers. We should avoid duplicating files and instead use scripts to generate files that can be generated.
  • Ideally, this is all automated whenever we tag the git repository.
  • If possible, I'd like to host all artifacts in https://quay.io/organization/orc. This is where we publish the ORC image, and where we're also going to push the OLM bundle image very soon.

Has anyone already explored kustomize to create helm charts? Since this project already depends on kustomize for a number of thing, it seems like a potentially good candidate.

mandre avatar Aug 26 '25 07:08 mandre

This is great to see activity pick up again in this PR. Any help is welcome, and a new pair of eyes will definitely help.

I'm sadly not experienced enough with helm to know the best practices and I'm afraid some of my feedback would go against some of the helm conventions. I count on you to tell me if that's the case.

That said, there are a few things I'd like us to keep in mind:

  • I would like to minimize the cost for the ORC maintainers. We should avoid duplicating files and instead use scripts to generate files that can be generated.
  • Ideally, this is all automated whenever we tag the git repository.
  • If possible, I'd like to host all artifacts in https://quay.io/organization/orc. This is where we publish the ORC image, and where we're also going to push the OLM bundle image very soon.

Has anyone already explored kustomize to create helm charts? Since this project already depends on kustomize for a number of thing, it seems like a potentially good candidate.

These are good points, I think releasing the chart whenever a git tag is created (with the same version as the orc controller, so chart version and appVersion match) is a common pattern for controllers (e.g. capi-operator does the same thing). ANd this reduces the overhead for the maintainers to release a new version.

Releasing the chart to quay should be possible as oci artifact, see this blog in section "Interacting With Helm and Quay"

simonostendorf avatar Aug 26 '25 08:08 simonostendorf

Why was this PR closed? Should a new one be opened?

simonostendorf avatar Sep 30 '25 17:09 simonostendorf

Why was this PR closed? Should a new one be opened?

I'm not sure why it was closed either. Feel free to open a new PR, I'd be happy for us to provide official helm charts, as there's apparently demand for it.

mandre avatar Oct 01 '25 10:10 mandre