jyn

Results 751 comments of jyn

> Can you compare the resulting runtimes for running the whole test suite it takes about 13.5 seconds for me to run the tests with `cargo nextest run` after they're...

i would expect it to only search inside `dir/`, the same as `git log -S foo dir`. i think the alternative you're suggesting is "show commits that modify dir/ and...

oh, it turns out git has a `--full-diff` option to opt into that behavior. so that's another option available, limit both by default but only limit one if someone opts-in.

Rather than implementing `help` manually, it might make sense to go through `visible_alias`, which makes help work out of the box without having to reimplement it: https://docs.rs/clap/latest/clap/struct.Command.html#method.visible_alias (i took a...

ah, i see, aliases can be multiple commands, they don't correspond 1-1 with a subcommand. so visible_alias won't work.

for anyone picking this up in the future - the way clap does this internally is https://docs.rs/clap_builder/4.4.18/src/clap_builder/builder/command.rs.html#4474-4487

@joyously do you mean the "unrecognized subcommand" error? yes, but that place is in clap itself: https://github.com/clap-rs/clap/blob/a7e04a53e4a9e310663a0cdb5bfb0753d84b82bd/clap_builder/src/error/format.rs#L529

completely unrelated but @joyously i *love* your username omg

i didn't know about trunk! that sounds like roughly what i want, but the exact behavior is not what i expect: > trunk(): Resolves to the head commit for the...

i wonder if `jj --version` is occasionally returning an error: https://github.com/martinvonz/jj/blob/7c87fe243c3b14f0321c2bd101af3879770cb90f/cli/build.rs#L60-L71 it would be nice to determine whether to run jj or to run git deterministically based on the presence...