cra-to-vite icon indicating copy to clipboard operation
cra-to-vite copied to clipboard

Published 20 hours ago • verified publisher icon jyash97

deprecated vite-react-jsx plugin in vite.config.js

Open Digital-Coder opened this issue 2 years ago • 4 comments

Thanks for this tool, but there is one issue. It creates vite.config.js with deprecated plugin vite-react-jsx, it needs to be replaced with @vitejs/plugin-react instead. because it causes some hot module replacement problems in vite@latest. I think vite.config.js should look like this : image see warning in their github repo : https://github.com/alloc/vite-react-jsx

Digital-Coder avatar Mar 09 '22 12:03 Digital-Coder

Hey @Digital-Coder 👋

Glad you like the tool. I created this one there was no official plugin and have not updated after that.

Are you interested in opening a PR? It should be fairly simple and straight forward.

jyash97 avatar Mar 09 '22 12:03 jyash97

I made these changes ,but how would I test my PR locally ? :D

Digital-Coder avatar Mar 09 '22 13:03 Digital-Coder

You can just do node ../path/to/repo in cra app or use npm link

jyash97 avatar Mar 09 '22 13:03 jyash97

@jyash97 why didn't this merge yet?

theskinnycoder avatar Jul 18 '22 07:07 theskinnycoder