jxtngx

Results 24 comments of jxtngx

apologies, I'm no longer able to work this.

Original errors after removing module from pyproject.toml can be viewed at: https://github.com/JustinGoheen/lightning/blob/lightningmodule/code-quality/type-hints/module_typehint_errors.md

apologies, I'm no longer able to keep this PR up to date.

the fix to this is that strategy must be `None`. maybe there should be a MisconfigurationException that follows the rank_zero_warn below? https://github.com/Lightning-AI/lightning/blob/619c2ff05827872973b2eed18d06651f7cd8bd4e/src/pytorch_lightning/trainer/trainer.py#L1797 suggested MisconfigurationException: ```python if self.accelerator == "mps" and...

all code is at https://github.com/JustinGoheen/lightning-pod/tree/bug/accelerator-mps/lightning_pod/core the issue was that I had accelerator and devices set to auto, and strategy set to single_device; single_device is not compatible with MPS and instead,...

@krshrimali I am working several other PRs for Lightning, and have this slated for next week https://github.com/users/JustinGoheen/projects/16/views/3

@krshrimali can you please let me know if this submission looks good, or if anything needs to be be changed

sounds good to me. thank you for the quick update.

@krshrimali I'll be submitting a new draft PR soon; I had to update the branch name and that deleted my previous draft PR.