Results 270 comments of João Oliveira

>My thinking was that maybe somebody is interested in this feature without the automatic upgrade. ah good question, but What would be the use case for that? >I'm thinking about...

Hi, have you seen the todos example and [how the database is inserted](https://github.com/seanmonstar/warp/blob/master/examples/todos.rs#L55)?

Hi, if I understand correctly you question, to return early with a custom `Rejection` you have to create an Error, which has to impl [`warp::reject::Reject`](https://docs.rs/warp/0.2.0/warp/reject/trait.Reject.html), and wrap it under [`warp::reject::custom`](https://docs.rs/warp/0.2.0/warp/reject/fn.custom.html)....

Hi, and sorry for the delay! So if I understand correctly what you are trying to achieve is being able to replace a `Known` rejection with a custom one right?...

still needs https://github.com/hyperium/hyper/issues/2321 no?

Hi! Both changes look good to me :) regarding the second one, with the current signature `json` also doesn't accept `Boxed` values, you have to pass by reference, see [here](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=a4f8ca3456831283a7e97f3520936a50)...

Hi, those traits are public only because `Filter` leaks them, but they are not meant to be used as building blocks for warp applications, `FilterBase` kinda refers that, and [here](https://docs.rs/warp/0.2.5/src/warp/filter/mod.rs.html#163)...

Oh sorry! And no, not pedantic at all, if you want to rebase your PR against master and add the limitations of parameter deserialization that would be great!

Hi, you can use a type to match the prefix, see https://github.com/seanmonstar/warp/issues/19#issuecomment-410392693