fannypack icon indicating copy to clipboard operation
fannypack copied to clipboard

Switches changing colour?

Open kochie opened this issue 6 years ago • 3 comments

The colours on the switch seem to change to the default theme when clicked. fannypack_switch You can see it in the docs

kochie avatar Jan 03 '19 00:01 kochie

Hey @kochie,

This is expected, as the Switch gains focus when it is clicked, triggering the focus outline. This is important for accessiblity. This is also evident with input fields. However, maybe we should make this a bit clearer? Adding a focus outline (of the same colour - maybe a lighter variant?) around the state outline could be a better solution... Thoughts?

jxom avatar Jan 03 '19 00:01 jxom

Yeah, that seem reasonable, I would expect that the focus colour for the switch would be the same as the switch colour or lighter as it's a bit jarring.

kochie avatar Jan 03 '19 05:01 kochie

Lighter/darker variant of the same colour would be nice - especially given we have associated the colours with meanings (i.e. red for danger, yellow for warning).

terencehuynh avatar Jan 18 '19 01:01 terencehuynh