bumbag-ui icon indicating copy to clipboard operation
bumbag-ui copied to clipboard

Published 20 hours ago • verified publisher icon jxom

onChange not being triggered for CheckboxGroup and SwitchGroup

Open harsilspatel opened this issue 3 years ago • 3 comments

To Reproduce Playroom links for SwitchGroup and CheckboxGroup.

harsilspatel avatar Jan 20 '21 08:01 harsilspatel

Hmm, yeah, seems like it doesn't get invoked for an uncontrolled group... However it does if you make it controlled (add a value prop) https://bumbag.style/playroom/#?code=N4Igxg9gJgpiBcIA8BhAFjMBrARhAHgOIBOEArgA4A6AdgAR00CGAtjALxUgDuMTALhmJdaDCBX4BLCDQDO7YAG1RDOsDoAbJjhgb4dAOQBlMjRoBPAwBo6ANyYayMfQdmmLBugF8rKhuq0dPUMAdUkaKEsbe0dnQ25wyM8fPzVNbV0XAHlbGGIwJll%2BazsHJxcIXPzC4u8VAF0vFRl0JhoAcw5gAAoASjp2AD46SDkIDRgAOg0Idu6uFrQ2zq5epvpS2IVXd0t1gHpBkC8gA

jxom avatar Jan 20 '21 08:01 jxom

Do you need the onChange handler for an uncontrolled input group?

jxom avatar Jan 20 '21 08:01 jxom

Thanks for the prompt reply! No worries, I'll have them as controlled input.

And since we're talking, do you mind fixing this to SelectMenu?: SelectMenuThemeConfig;?

harsilspatel avatar Jan 20 '21 09:01 harsilspatel