Jason Liu

Results 180 comments of Jason Liu

What are your thoughts on attaching the callbacks to the constructor of the client rather than the create call? from_openai(client, callbacks=[])

sorry been out. i want to do this but almost in the client, vs the create call. what are your thoughts on this?

we're going to clean this up a bit with a refactor that will make it easier

i think structured outputs will be better than strict json

Closing as part of repository maintenance for issues created before 2025.

happy to take a PR I think what happened was we need to pass client back into the validator now

Closing as part of repository maintenance for issues created before 2025.

Closing as part of repository maintenance for issues created before 2025.

fuck i think i merged vertex ai PR and fucked up this one, give me some time and i try to resolve it

@ivanleomk can you take ownership of this? test this locally and make sure everything works?