jj.lee
jj.lee
> One test to remove and we should be good. I'm in gym now, go back to fix soon!
@pierrejeambrun Do i need to modify code?
is it possible to take this issue for community contributor? this fixes don't seem difficult, and affected tests or additional tests also not difficult to write.
@dbeatty10 I want to solve this, and it'll be solved to fix [dbt_common.events._JsonLogger L195](https://github.com/dbt-labs/dbt-common/blob/16b683e7a5245e827a69faa1d0c4fd290fd8cc71/dbt_common/events/logger.py#L195) (then printed pretty json style) Is there a process for contributing to both repos (dbt_common, dbt-core)?...
> Thanks a lot for doing this refactor, @jx2lee. Changes like this really help the Cosmos code base be easier to maintain. > > I provided minor feedback inline, and...
> @jx2lee, this looks great, thanks for your contribution! > > Would it be possible to update the PR description to make it more informative and include an example DAG/code...
@pankajastro Great approach! Thanks for suggestion. I almost done ㅡneed to add unit test code. I'll push this changes and mark it ready for review soon, Thanks again!
@pankajastro I’ve updated the command to leverage `.airflowignore`. Really appreciate it if you could review my code. Thanks!