Problem in split in node

[fullfanta]

Dear @jwyang I downloaded the program and tested. It works good.

But, I found a problem in the function splitnode() in train_randomfs.m

There's code to get image index for the left and right child nodes:

lcind = find(pdfeats(ind_colmax(ind_max), :) < thresh);
rcind = find(pdfeats(ind_colmax(ind_max), :) >= thresh);

As the node goes deep, lcind and rcind only refer the front index of training images.

I think it should be changed as

lcind = ind_samples(find(pdfeats(ind_colmax(ind_max), :) < thresh));
rcind = ind_samples(find(pdfeats(ind_colmax(ind_max), :) >= thresh));

Then, lcind and rcind come from original image index.

Please check it.

[jwyang]

Hi, thank you very much for the correction. It is indeed a bug. I have fix it in the new version.

At 2015-02-27 20:22:03, "Jongju Shin" [email protected] wrote:

Dear @jwyang I downloaded the program and tested. It works good.

But, I found a problem in the function splitnode() in train_randomfs.m

There's code to get image index for the left and right child nodes:

lcind = find(pdfeats(ind_colmax(ind_max), :) < thresh); rcind = find(pdfeats(ind_colmax(ind_max), :) >= thresh);

As the node goes deep, lcind and rcind only refer the front index of training images.

I think it should be changed as

lcind = ind_samples(find(pdfeats(ind_colmax(ind_max), :) < thresh)); rcind = ind_samples(find(pdfeats(ind_colmax(ind_max), :) >= thresh));

Then, lcind and rcind come from original image index.

Please check it.

¡ª Reply to this email directly or view it on GitHub.