check-it-out icon indicating copy to clipboard operation
check-it-out copied to clipboard

chore(deps): remove danger

Open KalaRaja opened this issue 2 years ago • 5 comments

remove danger and its dependencies

✅ Closes: #493

Description

Uninstalled danger package removed config files related to danger - dangerfile.js, dangerfile.js.sample removed a job from Travis config that used danger package ref #493

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] Documentation update
  • [x] Refactor

Checklist:

  • [x] I have read the CONTRIBUTING document.
  • [x] My commits follow the commitizen commit convention
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.

KalaRaja avatar May 18 '22 02:05 KalaRaja

This pull request fixes 1 alert when merging 29bca12750494413bb6659485d9a58d4599edde4 into 000f416121c6e96e511d909c4ec1e4e123d01261 - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

lgtm-com[bot] avatar May 18 '22 02:05 lgtm-com[bot]

hello, @jwu910 I can review this if needed

a-camarillo avatar May 18 '22 17:05 a-camarillo

Thanks @a-camarillo great point.

Been a while since I looked at this project and chore does make more sense for this removal.

jwu910 avatar May 19 '22 15:05 jwu910

Hi @KalaRaja I see we've changed the title, but can you please update your commit message as well please?

If you need help, theres lots of info at this article.

jwu910 avatar May 25 '22 21:05 jwu910

Any update on this? May close this and bump the ticket back to todo soon

jwu910 avatar Aug 09 '22 16:08 jwu910

Stale

jwu910 avatar Feb 21 '23 00:02 jwu910