Refine from_f function documentation and add tests

Open npneeraj opened this issue 2 months ago • 6 comments

Summary

This PR fixes the incorrect panic documentation in Key::from_f and adds tests to verify behavior.

Resolves #108

Oct 18 '25 05:10 npneeraj

@orhun kindly review the PR, when possible. Thanks !

Oct 24 '25 18:10 npneeraj

@orhun can you please merge the PR so that its counted as an hacktoberfest contributions.

Oct 27 '25 04:10 npneeraj

I don't have permissions to merge on this repo. (I don't know why I was pinged as a code reviewer in the first place :D)

Oct 27 '25 06:10 orhun

Thanks for approving the changes, @orhun! Since you mentioned you don’t have merge permissions, could you please tag someone who does, so this PR can be merged?

Oct 28 '25 03:10 npneeraj

I think you already tagged them in the original issue

Oct 28 '25 07:10 orhun

I don't have permissions to merge on this repo. (I don't know why I was pinged as a code reviewer in the first place :D)

Kinda funny and based that you still reviewed

Nov 04 '25 12:11 tolik518