ott-web-app icon indicating copy to clipboard operation
ott-web-app copied to clipboard

Published 20 hours ago • verified publisher icon jwplayer

Fix / demo config reset

Open royschut opened this issue 5 months ago • 0 comments

Description

This PR fixes the "Unselect this config" button in demo mode, which was not responding. This happened because useTrackConfigKeyChange keeps undoing the change. Hard-setting the window.location.href fixes it, much like we do in all other config switch navigations. I have also removed some code that became obsolete.

Screenshot 2024-09-11 at 11 07 22

Steps completed:

According to our definition of done, I have completed the following steps:

  • [x] Acceptance criteria met
  • [ ] Unit tests added
  • [ ] Docs updated (including config and env variables)
  • [ ] Translations added
  • [x] UX tested
  • [x] Browsers / platforms tested
  • [x] Rebased & ready to merge without conflicts
  • [x] Reviewed own code

royschut avatar Sep 11 '24 09:09 royschut