ott-web-app icon indicating copy to clipboard operation
ott-web-app copied to clipboard

Unable to scroll landingpage / shelves

Open marcovandeveen opened this issue 1 year ago • 3 comments

For some viewers, when you use the right or left controls of theTileSlider component, it doesn't scroll.

It's not happening on all devices. But we have a couple of machines showing the behavior.

So far, it looks like it is NOT related to:

  • OS: happens on windows, mac, ios
  • Browser: happens on chrome, safari, firefox
  • Screensize: same device, different screens, same issue
  • Timing related: it happens consistently on a particular device

It seems to be introduced as in v4.26.0 , when the web app got upgraded to React 18.

https://github.com/jwplayer/ott-web-app/assets/42120041/e99e1010-dc89-4e61-9b85-8b5e506d0b17

https://github.com/jwplayer/ott-web-app/assets/42120041/f5aec2d4-6af5-426e-8b91-086fdb9bd300

https://github.com/jwplayer/ott-web-app/assets/42120041/0355e070-da19-408d-a2f9-d7f3ac75498f

https://github.com/jwplayer/ott-web-app/assets/42120041/76e781cd-9644-43b1-8c48-ac11948571a1

marcovandeveen avatar Jan 19 '24 09:01 marcovandeveen

Update: The behavior can be traced back to whether the slider is animated.

  • This is based on some 'browser magic' here: https://github.com/jwplayer/ott-web-app/blob/develop/src/components/TileDock/TileDock.tsx#L69
  • Some browsers give this as a setting, but others don't, and derive it from OS settings

The preview link in https://github.com/jwplayer/ott-web-app/pull/437/files fixes it.

marcovandeveen avatar Jan 19 '24 14:01 marcovandeveen

This issue is fixed by #437, right?

ChristiaanScheermeijer avatar Jan 26 '24 09:01 ChristiaanScheermeijer

@ChristiaanScheermeijer yes and no... that fix fixes the majority of issues, but we still have a repro on ipad that's still broken with the new code.

dbudzins avatar Jan 29 '24 11:01 dbudzins