ott-web-app icon indicating copy to clipboard operation
ott-web-app copied to clipboard

Published 20 hours ago • verified publisher icon jwplayer

Remove hardcoded spacings and add variables

Open ChristiaanScheermeijer opened this issue 2 years ago • 0 comments

Multiple SCSS files contain generic spacings which makes it difficult to change these. Also, the actual spacings don't align with the designs as well.

Examples:

https://github.com/jwplayer/ott-web-app/blob/e490487b61624f015bf1bbb79cc933a515acd9ac/src/components/VideoDetails/VideoDetails.module.scss#L13-L22

https://github.com/jwplayer/ott-web-app/blob/e490487b61624f015bf1bbb79cc933a515acd9ac/src/components/VideoLayout/VideoLayout.module.scss#L77-L93

https://github.com/jwplayer/ott-web-app/blob/e490487b61624f015bf1bbb79cc933a515acd9ac/src/containers/ShelfList/ShelfList.module.scss#L18-L30

The designs have the following spacings:

  • Mobile (<768): 16px
  • Tablet (>768 & 1024): 24px
  • Desktop (>1024): 56px

ChristiaanScheermeijer avatar Oct 07 '22 10:10 ChristiaanScheermeijer