ott-web-app icon indicating copy to clipboard operation
ott-web-app copied to clipboard

fix(auth): check the free value

Open AntonLantukh opened this issue 2 years ago • 1 comments

Description

  • for the params we expect to be true, we accept following values:

    • boolean true
    • 'true' / 'yes' strings in lower / upper case
    • numbers greater than 0
  • for the params we expect to be false, we accept following values:

    • boolean false
    • 'false' / 'no' strings in lower / upper case
    • 0 number

requiresSubscription is a deprecated property now.

This PR solves #103 .

Steps completed:

According to our definition of done, I have completed the following steps:

  • [ ] User stories met
  • [ ] Storybook stories
  • [ ] Unit tests added
  • [ ] Linting passing
  • [ ] Unit tests passing
  • [ ] Docs updated (including config and env variables)
  • [ ] Translations added
  • [ ] UX tested
  • [ ] Browsers / platforms tested
  • [ ] Rebased & ready to merge without conflicts
  • [ ] Reviewed own code

AntonLantukh avatar Jul 13 '22 14:07 AntonLantukh

Visit the preview URL for this PR (updated for commit 0c72ed9):

https://ottwebapp--pr112-bug-fix-free-item-pee9hrh9.web.app

(expires Wed, 07 Sep 2022 15:19:24 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

github-actions[bot] avatar Jul 13 '22 14:07 github-actions[bot]

Visit the preview URL for this PR (updated for commit a878ab6):

https://ottwebapp--pr112-bug-fix-free-item-12aha4ya.web.app

(expires Fri, 20 Jan 2023 14:57:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c198f8a3a199ba8747819f7f1e45cf602b777529

github-actions[bot] avatar Dec 14 '22 09:12 github-actions[bot]