py_cui icon indicating copy to clipboard operation
py_cui copied to clipboard

Allow for textbox alignment to top/middle/bottom

Open jwlodek opened this issue 4 years ago • 2 comments

Is your feature request related to a problem? Please describe. The slider can now be aligned to the top/middle/bottom of the grid space. It would be nice if the textbox could as well.

Describe the solution you'd like Similar functionality to the slider solution.

jwlodek avatar Feb 06 '21 20:02 jwlodek

When both is set to align at middle in some cases it start getting somewhat off.

image

Maybe this is because when aligning to middle, I made the SliderWidget to align based on box position excluding label, rather than entire lines including labels as I thought it gives more 'middle' feeling as more string masses are focused on middle point.

We'll have to match alignment some day, and decide which method must be used when aligning - Which alignment method do you prefer?

I'll try to make alignment by your preference for TextBox and make PR out of it after 1.3.0 is released.

jupiterbjy avatar Feb 20 '21 18:02 jupiterbjy

I think aligning based on the box is better, like you said. In the image above the volume slider looks better placed than the textbox, so I'd say that should be the solution. Also, once it is available, center alignment should be the default, as is the case for the slider.

jwlodek avatar Feb 25 '21 14:02 jwlodek