John Wiggins

Results 58 comments of John Wiggins

An attempt was made at this in #553 but abandoned. The real solution is likely completing #414

I never looked deeply into this, other than to see that AGG indeed has code for it. It may or may not be a good fit for the way `Paint`...

LOL, five years to the day... I can't even remember why I left this sitting open 🤷

The alpha _channel_ of an image was never ignored as far as I know. `GraphicsState.master_alpha` is only honored as of https://github.com/celiagg/celiagg/commit/517ecb2ec465d288bfcadc2264b487c7eb452370#diff-5c656a3b6d66092267808f277c3f025b44cf87afac8a5afe02b81572b8550e3c `GraphicsState.blend_mode` covers the many variations of [image blending](https://en.wikipedia.org/wiki/Blend_modes) but...

> What's the best way to start contributing to Enthought projects and start giving something back. One easy way to contribute would be opening issues for bugs you've run into....

Does this depend on the version of FreeType or is clang just more strict now?

Sure enough. CI is getting FreeType 2.11.1 which has the following declaration: https://gitlab.freedesktop.org/freetype/freetype/-/blob/VER-2-11-1/include/freetype/ftimage.h?ref_type=tags#L342 2.12.1 is unchanged: https://gitlab.freedesktop.org/freetype/freetype/-/blob/VER-2-12-1/include/freetype/ftimage.h?ref_type=tags#L342 But 2.13.3 has a new type: https://gitlab.freedesktop.org/freetype/freetype/-/blob/VER-2-13-3/include/freetype/ftimage.h?ref_type=tags#L353 Here's the "offending" commit: https://gitlab.freedesktop.org/freetype/freetype/-/commit/044d142be7b6a93b6940367a1bc5847451ff4775 Related...

Thanks for the initial PR. #134 should hopefully fix this.