use-package icon indicating copy to clipboard operation
use-package copied to clipboard

hook injection comment is wrong, or functionality is wrong

Open kanubacode opened this issue 7 years ago • 3 comments

This comment is either not true, or the functionality is not working correctly:

https://github.com/jwiegley/use-package/blob/d3ace722ea890f9e99054af4487eff65c4e36243/use-package-core.el#L255-L258

In spacemacs, a "post-config" config hook is only ever ran if there exists a use-package :config section.

kanubacode avatar Jun 10 '18 18:06 kanubacode

Can you give an example?

CeleritasCelery avatar Feb 08 '19 17:02 CeleritasCelery

It seems to me this broke during some refactoring. It was originally reported as #250; then https://github.com/jwiegley/use-package/commit/9ce42841c4cef69150ae89261ed8a6e881fae85c supposedly fixed it, and the part where hooks are run when e.g. :config nil is specified still works, but when :config is left out completely the hooks for it aren't run anymore.

flodiebold avatar Mar 17 '19 12:03 flodiebold

Is this still an issue?

skangas avatar Nov 13 '22 20:11 skangas