Traceback in git-find...

[jszakmeister]

First, thanks for making all of these scripts available. I'm finding several of them to be really useful!

I was looking at git-find today, and thought I'd give it a try. So I ran it against the git repo (the real Git repo) and got this:

/Users/jszakmeister/bin/git-find:99:in `assign_name': stack level too deep (SystemStackError)
from /Users/jszakmeister/bin/git-find:89:in `each'
from /Users/jszakmeister/bin/git-find:89:in `assign_name'
from /Users/jszakmeister/bin/git-find:99:in `assign_name'
from /Users/jszakmeister/bin/git-find:89:in `each'
from /Users/jszakmeister/bin/git-find:89:in `assign_name'
from /Users/jszakmeister/bin/git-find:99:in `assign_name'
from /Users/jszakmeister/bin/git-find:89:in `each'
from /Users/jszakmeister/bin/git-find:89:in `assign_name'
 ... 4497 levels...
from /Users/jszakmeister/bin/git-find:174:in `process_names'
from /Users/jszakmeister/bin/git-find:183
from /Users/jszakmeister/bin/git-find:183:in `each'
from /Users/jszakmeister/bin/git-find:183

The exact command line I used was: git find bd40d252ec1ed2716ac9e6bbeab48b3b40bd0d58

Again, that was in the official git repo.

Thanks again!

[javabrett]

I get similar, but I least I have some output to go on:

$ git find bd40d252ec1ed2716ac9e6bbeab48b3b40bd0d58
Processing refs history ...
refs/heads/doc-filter-branch-move-tree-fix
refs/heads/doc-filter-branch-move-tree-fix~1
refs/heads/doc-filter-branch-move-tree-fix~2
refs/heads/doc-filter-branch-move-tree-fix~3
refs/heads/doc-filter-branch-move-tree-fix~4
refs/heads/doc-filter-branch-move-tree-fix~5
refs/heads/doc-filter-branch-move-tree-fix~6
refs/heads/doc-filter-branch-move-tree-fix~7
refs/heads/doc-filter-branch-move-tree-fix~8
refs/heads/doc-filter-branch-move-tree-fix~9
refs/heads/doc-filter-branch-move-tree-fix~10
refs/heads/doc-filter-branch-move-tree-fix~11
refs/heads/doc-filter-branch-move-tree-fix~12
refs/heads/doc-filter-branch-move-tree-fix~13
refs/heads/doc-filter-branch-move-tree-fix~14
refs/heads/doc-filter-branch-move-tree-fix~15
refs/heads/doc-filter-branch-move-tree-fix~16
refs/heads/doc-filter-branch-move-tree-fix~17
refs/heads/doc-filter-branch-move-tree-fix~18
refs/heads/doc-filter-branch-move-tree-fix~19
refs/heads/doc-filter-branch-move-tree-fix~20
refs/heads/doc-filter-branch-move-tree-fix~21
--- >-8 --- >-8 ---  >-8 ---  >-8 ---  >-8 ---  
refs/heads/doc-filter-branch-move-tree-fix~2254
refs/heads/doc-filter-branch-move-tree-fix~2255
refs/heads/doc-filter-branch-move-tree-fix~2256
refs/heads/doc-filter-branch-move-tree-fix~2257
git-find:91: stack level too deep (SystemStackError)

I don't know Ruby well. Perhaps offset variable is not being incremented properly, or is local, or is somehow not being updated properly in the recursion.

It's not clear to me how the recursion is supposed to exit. For long-history branches it looks like it continues forever, or at least until the stack blows.