requirejs-rails icon indicating copy to clipboard operation
requirejs-rails copied to clipboard

Fix: check environment Gzip option

Open Strech opened this issue 9 years ago • 7 comments

In the sprockets you can disable gzipping your assets, but requirejs-rails ignore this option. The second commit change Sprockets env call to the defined variable, instead of new ::Rails.application.assets call.

Strech avatar Mar 24 '16 12:03 Strech

Ah, I found that gzip? appears only in sprockets 3.x, will add check about gzip? method

Strech avatar Mar 25 '16 22:03 Strech

@carsomyr Hi, can you have a look on this PR?

Strech avatar Mar 29 '16 10:03 Strech

:+1: :trollface:

Deradon avatar Mar 29 '16 15:03 Deradon

Anyone? Ping @carsomyr, @billmag, @jwhitley

scudelletti avatar Apr 29 '16 15:04 scudelletti

Hey @scudelletti -- apologies, but I'm no longer actively working on the project that uses this and have been out of touch on recent changes. @jwhitley or @carsomyr will have to reply.

billmag avatar Apr 30 '16 16:04 billmag

Thanks for the reply @billmag we will wait for them.

scudelletti avatar Apr 30 '16 20:04 scudelletti

Sorry, I'm not much immediate help either. @carsomyr has been the active maintainer of this project for years now; I'm very out of touch. However, I'm happy to help get some additional maintainer assistance in place if life's pulled Roy in other directions.

jwhitley avatar May 02 '16 20:05 jwhitley