Joseph Werle
Joseph Werle
why move all of this into a `sdk` folder? if we care so much about node compat, why not create a `node` folder and put the node.js code there?
I guess maybe a `src` directory could work but the node stuff feels out of place when this module is intended to work in one type of of environment 🤷🏼♂️
I guess I am just not totally sold on why this repository needs to have anything to do with node, or even if it does, supports it in any first...
> > nodejs FS when you can just import `node:FS| directly. This module is for the SDK webview environment > > yes but what we are doing here is trying...
@wangfenghappy which value should this be?
i'll give this another review - cc @hyperupcall
we fixed this in `next` and we actually handle relative paths for you in the `Worker` implementation :)
seems pretty straightforward - https://developer.apple.com/documentation/uikit/uiviewcontroller/prefersstatusbarhidden?language=objc
we can make this a configuration option in `socket.ini`