GoogleMusic.bundle icon indicating copy to clipboard operation
GoogleMusic.bundle copied to clipboard

Test plugin with a user without All Access

Open jwdempsey opened this issue 10 years ago • 7 comments

jwdempsey avatar Dec 16 '14 05:12 jwdempsey

I don't have an All Access account and I get a "This channel is not responding." message when loading the plugin. However, I also have two-factor authentication enabled on my account, so I'm not exactly a great test case.

csparker247 avatar Dec 17 '14 22:12 csparker247

Thats good to know. Did you create a application password to use with the plugin?

jwdempsey avatar Dec 18 '14 14:12 jwdempsey

Oh my goodness, I didn't even know those existed. That got me logged in. I'll test the functionality and update here with comments. Thanks!

csparker247 avatar Dec 18 '14 14:12 csparker247

Oh good! I'm hoping most things work but I haven't tested it in a long time.

jwdempsey avatar Dec 18 '14 14:12 jwdempsey

I tested on both Android and Plex Web and It seems as if all the basic functionality is there. Playlists and stations both work, even the I'm Feeling Lucky Radio. I did find one very small "bug."

If you make a new playlist in Google Music, it doesn't get pulled into the plugin. I imagine the plugin is keeping some cache with a set TTL, though, so that's not surprising. I'll keep an eye on it to see when that playlist finally shows up.

That seems minor, though. I'd say you're free and clear to start filtering on the data you're pulling from Play Music. The artist view is a particular mess if you click into an Artist with multiple albums. I can't seem to find any sort of reason for how it's organized.

Great work, though! The basic playback and section functionality performed flawlessly!

csparker247 avatar Dec 18 '14 17:12 csparker247

You are right, I do cache the data I get from Google. I might refactor the plugin so that this doesn't happen though. I'm still deciding on that. I am actually going to add an issue for this as well as the artist view. I'm thinking it makes sense to sort the albums based on release date (assuming I have that data). Thanks for all of your help!

jwdempsey avatar Dec 18 '14 18:12 jwdempsey

Np. Glad to help. If I get up to speed on my Python, I might have time to contribute in the future.

csparker247 avatar Dec 18 '14 21:12 csparker247