Wei

Results 149 comments of Wei

I am willing to implement a webhook to handle everything like this.

Can you help take a look at this? @jonathan-innis @ellistarn

The problem is here: https://github.com/kubernetes-sigs/karpenter/blob/c4be45e04079f0d9313150b3ae7b5313132b0e36/pkg/controllers/provisioning/scheduling/queue.go#L76

I can help fix this issue if you think it is a real problem.

> This is a pretty major change. Would you be interested in writing an RFC? https://github.com/kubernetes-sigs/karpenter/tree/main/designs https://karpenter.sh/docs/contributing/design-guide/ Sure, I will do it.

/cc @RainbowMango I don't see the purpose of `Immediately`. Should we consider deprecating it?

By the way, should we re-enqueue the item if an unexpected error happens, like a broken Internet connection? For example, the following code: https://github.com/kubernetes-sigs/karpenter/blob/14f12dd82b6c8dfc9bff634df0527ae718faa748/pkg/controllers/nodeclaim/lifecycle/registration.go#L59 I prefer to re-enqueue them, make...