Jason Walton

Results 118 comments of Jason Walton

Sorry that took so insanely long. :( Thank you so much for doing this. I really like that this has no external dependencies now. I did rename `makeRequest` back to...

I just tried cloning a fresh copy ``` $ git clone [email protected]:jwalton/node-supertest-fetch.git $ cd node-supertest-fetch $ npm install ``` And then I added this to test/test.ts: ```ts it('should generate a...

If you want another quick test, try writing a jest test that just does something like: `assert.deepStrictEqual({a: "foo"}, {a: "bar"});` and see what that does. If that doesn't produce a...

I believe the technical term I'm looking for is "wat!?" This is exactly what we're doing in supertest-fetch. -_-

> does a connectFailed not lead to a reconnection attempt? It should keep reconnecting until you ask it to stop. If you suspect this is because of some kind of...

By and large, this library attempts to be a thin wrapper around the underlying [amqplib](https://amqp-node.github.io/amqplib/), and it would do the same thing. I'm not sure if graceful close is something...

There have been a couple of changes in [promise-breaker](https://github.com/jwalton/node-promise-breaker/blob/master/CHANGELOG.md) in 3.0.0 an 4.0.0 that were subtle. I'm kind of tied up with some work related stuff right now, but I'll...

I added a [publish](https://github.com/benbria/node-amqp-connection-manager/blob/master/examples/pubsub-publisher.js) and [subscriber](https://github.com/benbria/node-amqp-connection-manager/blob/master/examples/pubsub-subscriber.js) example to the examples folder. Both of these are working fine for me, though. Do you have an example that recreates the problem you're...

If someone can provide me with a test case or with even a sample app that presents this behavior with RabbitMQ, I'm more than happy to look into it. I...

This is more a question for ampq.node project, I think. From what I know, every message is assigned a "delivery tag"; these tags are per-connection, and they need to match...