Jason Walton

I'll point out that if you generate a LUT at runtime (similar to what I did in https://github.com/chalk/ansi-styles/pull/68), then generating the LUT is quite fast - there's only 256 values...

Why not `/%25[0-9a-fA-F][0-9a-fA-F]/g`? What is this doing exactly? :P

Oh, it's not just trialing chars: ```js const template = new UriTemplate('/a/{b}/c'); template.fromUri('/a/foo/bar/c'); // Returns `{b: 'foo/bar'}` ``` To my mind this is the main difference between the template '/a/{b}/c'...

So, for starters, if you pass in the rate limit numbers that Riot assigns you, it's unlikely you'll ever get a 429 since [lol-js will rate limit for you](https://github.com/jwalton/lol-js/blob/5e67072ccdc8f6501eb532c558fd4c466132067e/src/client.coffee#L96). But,...

Ooh. I didn't notice Riot had added a [current game API](https://developer.riotgames.com/api/methods#!/976). I will definitely look into adding support for this.

Yup. I haven't logged into LoL in a long time though. :P If you want to submit a PR for the new API, I'd certainly be interested in taking it....

Yeah, I was thinking about this while I was writing it, actually. I'd welcome a PR. :) On Apr 21, 2015 1:36 AM, "Cezar “ikari” Pokorski" [email protected] wrote: > Hi!...

I’m very interested in having a look at this. From the description it sounds fantastic. But, I’ve got a touch of strep throat right now and a 102 fever so...

No worries.  I get too many GitHub notifications and it’s easy to forget about them.  Pinging me is the best way to get me merge something.  :)On Oct 26, 2023,...

One thing I'm curious about - why rename `makeFetch` to `makeRequest` and `fetch` to `request`?