Jason Walton

Results 118 comments of Jason Walton

If you want to write something up, please submit a PR. :) We just use RabbitMQ for pub/sub and work queues. :P

Sorry I took so long to respond - missed the notification about this issue. Yeah, that's definitely a possibility. Right now messages are stored in [`this.messages` in the ChannelWrapper](https://github.com/benbria/node-amqp-connection-manager/blob/0dd95a3cc970c94017d14ba52981137171c1a8ed/src/ChannelWrapper.coffee#L32). Probably...

That is pretty slick. So long as it's optional, I'd definitely take a PR.

ChannelWrapper is an EventEmitter, so maybe just emit a "droppedMessage" event and let the caller decide how they want to handle it? It would be slick if callers could pass...

> maybe a bit out of the scope Yeah, I hesitated to even suggest it. :P

Whenever a connection fails, you'll get a `disconnect` event [even amqp-connection-manager is not currently connected to RabbitMQ](https://github.com/benbria/node-amqp-connection-manager/blob/6b512e8a84453ea8ff860bc0f3ce8615000f005a/src/AmqpConnectionManager.js#L191). But, amqp-connection-manager doesn't know the difference between trying to connect to a bad...

Sorry for taking so long to get back to you - we had a family emergency over here. All of the [GitHub runners](https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-software) come with AWS preinstalled. If you're using...

Although... We could swap in the aws-sdk and grab the login password that way... I'm going to leave this open - I'll make this change when I get a chance.

Here's a quick stab at rewriting the example from the README using callbacks: ```js var amqp = require('amqp-connection-manager'); // Create a new connection manager var connection = amqp.connect(['amqp://localhost']); // Ask...

Fixed in 1.3.6. I also added a [callback-based test case for `publish()`](https://github.com/benbria/node-amqp-connection-manager/blob/master/test/ChannelWrapperTest.coffee#L203-L218). One thing about using callbacks - you need to specify the `options` parameter, even if you have no...