json-logic-js icon indicating copy to clipboard operation
json-logic-js copied to clipboard

Would you be interested in a code merge? (json-logic-engine)

Open TotalTechGeek opened this issue 1 year ago • 0 comments

Hello!

I am and have been a huge fan of JSON Logic & the language you've designed.

For a while I've maintained an alternative JSON Logic implementation, and I'm curious if there's any interest in potentially doing a code merge? Introducing some of the work done for json-logic-engine into json-logic-js?

I would be happy to make efforts to ensure that any remaining differences are removed, mainly just:

  • Empty Arrays are truthy in mainline json-logic.
  • "all" with zero items evaluates to true

However, my codebase is not designed for as much compatibility as your project is (it most certainly would not work with IE8), though it should be able to run in all currently supported web browsers.

If you'd prefer for our projects to remain separate, there won't be any hard feelings 😄.

TotalTechGeek avatar Dec 16 '22 05:12 TotalTechGeek