Matt Sicker

Results 161 comments of Matt Sicker

Alright, I give up on that failing test on CI. It works on my machine. Log as proof: ``` $ mvn -P'!noIT' clean test -Dtest=TheFlintstonesTest\#loadGroupFromAlias [INFO] Scanning for projects... [INFO]...

I isolated the cause of the test failure by first removing my changes to custom.sh which made the test pass again. Changing the ordering of the commands in it didn't...

@fbelzunc @jeffret-b I split out the new test and reverted my changes to the old test. Everything should be good to go now. Please review.

Re-triggering due to docker build timeout.

Not sure why the test aborts before it's finished building the image, so this may take a few tries to get it to finish building.

@jeffret-b @fbelzunc tests passing now

So this PR is ready to merge. However, based on some bug reports we got related to the LDAP change matching this AD change, there seem to be a plugin...

https://github.com/jenkinsci/mailer-plugin/pull/104 for one issue surfaced from the LDAP PR that would likewise apply to this PR.

And filed https://github.com/jenkinsci/email-ext-plugin/pull/277 for the other related issue. Once those are both merged, this PR is good to go.

This PR is looking decent. I think you might be better off adding the new constructor parameter in the `@DataBoundConstructor` as a setter method with `@DataBoundSetter` to avoid having to...