bitcoin-prometheus-exporter icon indicating copy to clipboard operation
bitcoin-prometheus-exporter copied to clipboard

Option to disable banlist metrics

Open mmilata opened this issue 4 years ago • 3 comments

I'm using a banlist that's got ~5000 entries which make the exporter output huge. It's not fatal but it's not ideal either. I wonder if there's some more elegant solution than introducing "boolean" env variable to turn it off?

mmilata avatar Jun 10 '20 21:06 mmilata

Instead of the bitcoin_ban_created and bitcoin_banned_until metrics, I expect you probably only care about aggregate ban metrics, not any of the per-peer metrics.

Maybe just a high level bitcoin_banned_peers gauge, along with the ability to turn off the per-client metrics.

jvstein avatar Jun 17 '20 22:06 jvstein

Yep, exactly.

mmilata avatar Jun 17 '20 22:06 mmilata

Also consider Prometheus' general advice on labels: https://prometheus.io/docs/practices/instrumentation/#do-not-overuse-labels

mmilata avatar Jun 17 '20 22:06 mmilata