rules_pycross icon indicating copy to clipboard operation
rules_pycross copied to clipboard

fix(pdm): Ignore some dependencies with markers that are not met by any target enviroment

Open gfringeli opened this issue 11 months ago • 2 comments

Idea to improve (not perfectly solve) the situation described in #115.

gfringeli avatar Jan 25 '25 16:01 gfringeli

I think this solution is reasonable: Under the assumption that the provided PDM lockfile is "correct", then any such missing dependency must be due to the dependency not being needed. At least under this assumption, the raised exception is exclusively triggering false positives, so removing it strictly improves the situation.

burnpanck avatar Apr 18 '25 10:04 burnpanck

This fixes a problem I have too with pytest having an optional dep on Python <3.11. I agree this is reasonable given that we should assume PDM lockfiles are correct, as @burnpanck said.

cwill747 avatar Apr 25 '25 12:04 cwill747