external_service icon indicating copy to clipboard operation
external_service copied to clipboard

Configurable rate limit backend

Open fishtreesugar opened this issue 3 years ago • 3 comments

is it a good idea?

fishtreesugar avatar Dec 13 '21 15:12 fishtreesugar

I would just replace ex_rated with Hammer completely, as the latter supersedes it and has pluggable backends itself. To have a pluggable backend which itself has pluggable backends looks like an anti-pattern (a knob on a knob)

a3kov avatar Apr 06 '23 22:04 a3kov

I'll have a look at hammer and see if it might be a good replacement for ex_rated. At first glance I worry that using hammer would require the user to configure it in their app configuration, and I would prefer not to place that burden on the user. But I haven't looked into it very deeply yet, so I could be mistaken.

In any case, I wouldn't mind getting rid of the dependency on ex_rated and either use hammer (if it's a good fit) or possibly just roll my own rate-limiting implementation into external_service.

jvoegele avatar May 15 '23 18:05 jvoegele

@jvoegele first of all thanks for this great library!

Is there any news on adding support to Hammer?

GiovanniHessel94 avatar Nov 08 '23 00:11 GiovanniHessel94