BrowserFS icon indicating copy to clipboard operation
BrowserFS copied to clipboard

TypeError: PATH.join2 is not defined

Open notiv-nt opened this issue 5 years ago • 4 comments

image

I thought to replace everywhere with just join, but the tests don't work on my computer, I can't check

image

notiv-nt avatar Mar 27 '19 16:03 notiv-nt

https://github.com/notiv-nt/BrowserFS/commit/e4bcd55a0103c38cec15a35273bd1636a2037241 Works for me

notiv-nt avatar Mar 27 '19 16:03 notiv-nt

@notiv-nt Interesting; I wonder if Emscripten changed their internal API. Could you open a PR so I can review and potentially merge?

jvilk avatar May 29 '19 02:05 jvilk

@jvilk ?

notiv-nt avatar Jul 11 '19 19:07 notiv-nt

Got around this by passing a slightly modified path to the plugin.

import * as path from "path";

const BFS = new BrowserFS.EmscriptenFS(FS, { join2: path.join, ...path });

juhana avatar Sep 12 '19 13:09 juhana

Closing (stale). If you would like to reopen this issue, please do so by creating a new issue in the relevant repositories of @browser-fs

james-pre avatar Oct 25 '23 00:10 james-pre