BrowserFS icon indicating copy to clipboard operation
BrowserFS copied to clipboard

More CLI options for `make_http_index`?

Open billiegoose opened this issue 6 years ago • 4 comments

@jvilk I ran into an issue where this line in /scripts/make_http_index.ts:

// ignore non-essential directories / files
if (ignoreFiles.indexOf(file) !== -1 || file[0] === '.') {
  return;
}

forced me to fork your script. I needed to include hidden filenames (like .eslintrc) in my index. My question for you is: should I continue using my fork (and possibly publish it) or would you be receptive to PRs adding more bells and whistles to this script?

billiegoose avatar Apr 25 '18 23:04 billiegoose

I would probably start by adding support for passing in globs, and writing the result to stdout.

billiegoose avatar Apr 25 '18 23:04 billiegoose

Would it be acceptable to add a --include-hidden-files switch? That would be simplest to add.

jvilk avatar Apr 26 '18 14:04 jvilk

I could live with that. 😀

billiegoose avatar Apr 26 '18 15:04 billiegoose

Please use https://github.com/browser-fs/core/issues/16

james-pre avatar Oct 25 '23 00:10 james-pre