Jan Vesely
Jan Vesely
typecheck-decorator has been removed. I think we can close this one, unless beartype has the same issue
@dependabot rebase
Fixed in #2975
Removing the `def _update(self, params=None, context=None):` overload fails only one test: ``` tests/composition/test_control.py::TestControlMechanisms::test_modulation_simple[ExecutionMode.Python-CostFunctions.DURATION--] E AssertionError: E Not equal to tolerance rtol=1e-07, atol=0 E E Mismatched elements: 5 / 5 (100%)...
likely, both `def _update` and `def calculate_costs` can be removed since they just duplicate the calculations done in `TransferWithCosts`
Note that this is not the only place that recalculates the costs. composition `_get_total_cost_of_control_allocation`, calls `controller.parameters.costs_get` which executes `_control_mechanism_costs_getter` which again recalculates all the costs that have just been calculated...
> Considering duration cost uses an integrator by default, I wonder if instead removing the recalculation in `_control_mechanism_costs_getter` is the way to go. It seems like it could easily end...
I think we should leave this open until all the other issues are investigated e.g.: > removing the recalculation in _control_mechanism_costs_getter
I don't see how calling `reseed_rng` helps here. The implementation is not reading the seed from anywhere [0,1]. The only way I found to set a custom seed is in...
> Oh your right, I figured it cached the seed. Well, maybe we will just have to settle for something like a warning message when seed is passed to PEC...