Jeff Verkoeyen
Jeff Verkoeyen
Note for anyone trying out the Playdate branch locally, here's the basic setup instructions. First, get the Playdate SDK: https://play.date/dev/ and also the rgbds binaries: `brew install rgbds` Once that's...
Input working :D https://user-images.githubusercontent.com/45670/183335587-3c836c68-aaaa-41a6-9436-9e49ab0711ea.mov
https://twitter.com/featherless/status/1556488811584143360?s=21&t=QZXQfJoU-Z8tZUJXLqa0dw might work better on Twitter? Haven't tested performance of other emulators yet! No hardware yet unfortunately so any testing I can do is not super trustworthy :(
> CallbackBridgeDelegate and other exported symbols should have the GB prefix (e.g. GBCallbackBridgeDelegate). The Document class is an exception due to an Apple convention. Ah! I was wondering about that;...
> nonnull and nullable should not be used – nullability is explicitly not used in SameBoy, because the Objective-C implementation of this feature encourages bad practices such as dangerous casting,...
> * `gotNewSample` is actually optional, it will only be called if you first set the sample rate > * `initWithGB` should be `initWithGameBoy` > * The `{` following a...
> * I don't think `connectPrinter` makes sense as a bridge API, `connectLinkCableWithPartner` should be `enableSerialCallbacks` instead and should not have a partner parameter, as a Link Cable between two...
> I don't think connectPrinter makes sense as a bridge API Agreed that this API felt a bit out of place. I've replaced the method with an externalized C callback...
Gently checking in here to see if there's anything remaining for me to clean up.
No worries! Thank you for the great feedback :)