argminmax icon indicating copy to clipboard operation
argminmax copied to clipboard

fix build error on nightly-2025-04-25

Open JosiahWhite opened this issue 8 months ago • 1 comments

JosiahWhite avatar Apr 25 '25 20:04 JosiahWhite

Seems like a portion of the tests are failing due to the Rand dep needing updated, and the others are failing to build due to ndarray depending on the broken version of this crate.

How do you suggest I resolve this?

JosiahWhite avatar Apr 25 '25 21:04 JosiahWhite

CodSpeed Performance Report

Merging #73 will not alter performance

Comparing JosiahWhite:fix-nightly-compile-error (2b78a0e) with main (585c5cf)

Summary

✅ 168 untouched benchmarks

codspeed-hq[bot] avatar May 07 '25 12:05 codspeed-hq[bot]

Thanks for submitting this PR @JosiahWhite

I fixed up the tests and had to update 1 more type for float16 data types (this got only triggered when building with --all-features, as f16 is not a native rust data type).

jvdd avatar May 07 '25 12:05 jvdd