generator-angular2-library icon indicating copy to clipboard operation
generator-angular2-library copied to clipboard

force user to use node 8.x to use util.promisify

Open aelbore opened this issue 7 years ago • 6 comments

since 8.x is the LTS version for node, why not change the promisify function to require('util').promisify

aelbore avatar Jan 31 '18 10:01 aelbore

@aelbore — What would be the benefit from a user's perspective? I'm guessing some people still use node v6. What would be the benefit of forcing them to use node v8? Thanks in advance!

jvandemo avatar Feb 04 '18 21:02 jvandemo

@jvandemo i notice that your using promisify to make the fs.readfile to promise, and also since node v8 is the LTS version in a few months theres no support for v6. async/await to make code shorter.

aelbore avatar Feb 06 '18 16:02 aelbore

@jvandemo by the way i got lightweight cli to bundle angular as a package. you might consider this also. https://github.com/ngx-devtools/cli or just npm install -g @ngx-devtools/cli then ngx run bundle thanks.

aelbore avatar Feb 06 '18 16:02 aelbore

I wouldn't see any problems about dropping the support for node v6

izifortune avatar Feb 20 '18 20:02 izifortune

@aelbore — Would you be interested in creating a PR to update the code to node v8? Thanks!

jvandemo avatar Feb 20 '18 22:02 jvandemo

@jvandemo sure will create a PR :)

aelbore avatar Mar 13 '18 15:03 aelbore