generator-angular2-library icon indicating copy to clipboard operation
generator-angular2-library copied to clipboard

Feature request: Allow double quotes for template inlining

Open Shackless opened this issue 7 years ago • 2 comments

As far as I understand, the regex in the gulp function inlineTemplate() only searches for a string in the format templateUrl: '...' and does not cover double quotes notation like templateUrl: "...". I can create a pull request for this but are there other parts in the project that expect us to use single quotes?

Shackless avatar Sep 12 '17 08:09 Shackless

I have extended the regular expression for double quotes, which has worked without further modifications.

mwellner avatar Oct 17 '17 12:10 mwellner

I can't believe it was not working cause the double quotes... Why is that?? Still not working in the latest version @12.4.1

tonysamperi avatar May 31 '18 12:05 tonysamperi