generator-angular2-library icon indicating copy to clipboard operation
generator-angular2-library copied to clipboard

feat(umd): uglify the umd bundle

Open izifortune opened this issue 7 years ago • 8 comments

Umd bundle will be minified using the following rollup plugin: https://github.com/TrySound/rollup-plugin-uglify

izifortune avatar Jun 19 '17 21:06 izifortune

@izifortune — Awesome, thank you for your contribution!

Is it possible to generate 2 versions of the UMD bundle?

  • *.umd.js: non-minified UMD bundle
  • *.umd.min.js: minified UMD bundle

That would be similar to how Angular Material generates bundles: https://github.com/angular/material2-builds/tree/master/bundles

Would you be able to do that? Thanks again! 👍

jvandemo avatar Jun 20 '17 05:06 jvandemo

@jvandemo i had to create another gulp task for this hope you don't mind.

izifortune avatar Jun 29 '17 19:06 izifortune

Curious why this hasn't been merged into current master? Thanks!

chrisalexander55 avatar Aug 12 '17 16:08 chrisalexander55

@izifortune — I'm sorry, I missed your update. I will check it later this week and merge if all works as expected.

Thanks again for your contribution! 👍 /cc @chrisalexander55.

jvandemo avatar Aug 14 '17 00:08 jvandemo

@jvandemo no worries happy to help :)

izifortune avatar Aug 20 '17 13:08 izifortune

when is that cool feature available?

fishme avatar Jan 07 '18 18:01 fishme

Resolved conflicts

izifortune avatar Jan 12 '18 21:01 izifortune

@izifortune — Looks like there is still a conflict. Would you be able to resolve it? If not, I can have a look at it as well. Thanks again! 👍

jvandemo avatar Jan 14 '18 17:01 jvandemo