Jonathan Vanasco

typing does not (often) match doctrings

4

While upgrading a project that depends on Certbot, I encountered a handful of typing errors. One such example is in `crypto_utils.get_names_from_cert` https://github.com/certbot/certbot/blob/master/certbot/certbot/crypto_util.py#L459-L470 The `cert` param is typed for bytes, but...

Change-Id: Id33779cb126a700d9adebe5f08f9d6c085589db4 Under 2.0, calls to `in_` and `not_in` no longer accept an explicit `.subquery()`. Passing a `.subquery()` will cause typing issues from MyPy AND will raise runtime warnings. There...

mypy: coerced legacy syntax with subquery can not be typed

7

### Describe the bug I found a typing oddity with 2.0 that is not in the guide. Legacy code utilizing a `Session().query().subquery()` will run fine (and emit warnings that is...

I believe this is Python 2 code and can be safely removed. correct?

2

https://github.com/sqlalchemy/dogpile.cache/blob/fa090bef0efd4efc350bc85f5b7f3c085c812384/dogpile/cache/backends/redis.py#L9 i will generate the PR if someone can confirm

KeyType might not always be `str`

2

dogpile.cache.api defines `KeyType: str` https://github.com/sqlalchemy/dogpile.cache/blob/main/dogpile/cache/api.py#L44-L45 Redis offers a hash/dict mapping for storage, which is accessible using the `.hmget`/`.hmset` methods from redis-py. The current backends do not support this, but third-party/developer...

aggressively converts html entities, not really usable for email templates

9

First off, thanks. This is a great package + well designed & documented. I ran into some issues while trying to get this to work with mako templates (which i...

re mailing list comments ;)

It would be great if pystache had a tool to properly validate a template. I slapped this together , but it could be wrong. I don't know the internals correctly,...

transaction support

4

it would be great if this supported joining the pyramid_tm transaction for example, if I call something an async task, it could defer sending the request to the broker until...

`bodywidth` is currently specified in an init argument, defaulting to `config.BODY_WIDTH`. https://github.com/Alir3z4/html2text/blob/master/html2text/__init__.py#L43 A problem with this approach: the `__init__` function creates the default value for bodywidth when it is interpreted....