Jonathan Vanasco
Jonathan Vanasco
That makes sense. I've just been using TypedDicts in the test suites, then `type: ignore` the extra key on those tests. I just find it a bit easier to catch...
Ready for another review. General Concerns: Redis Backend: * socket_keepalive_options Redis has this typed as: https://redis.readthedocs.io/en/latest/connections.html `socket_keepalive_options (Optional[Mapping[int, Union[int, bytes]]])` * but test_redis_backend has `"socket_keepalive_options": {4, 10.0}` test_decorator.py * `test_sha1_key_mangler_bytes_py3k`...
> regarding get vs pop, in my opinion we could replace all of the with gets, I'd prefer that. IIRC, the usage of pop is a legacy behavior. these constructors...
Let me see what I can pull together in the next 30 minutes.
I added some backend tests as `BackendArgsAntiMutationTest`. I'm hoping the redis/valkey clusters pass in the cloud; I can't run them locally due to an instant fail if they cluster servers...
@CaselIT Done, but there is a merge commit
> im dying for either of this #270 or #274 to please put a test that is across all backends (meaning, in dogpile/cache/testing/fixtures) to assert that: > > 1. keys...
I switched the backend test from test_region to GenericBackendFixture as requested, it's in #275 as separate PR for easier comparison. I do want to note there is no exiting test...
This has been updated against main. The previously requested tests were removed as they are now unnecessary.
Since I got some messages after being cross-referenced to this, hopefully I can help a bit. To clarify: * Python introduced some changes to the basic validation in which, amongst...