pack.alpha icon indicating copy to clipboard operation
pack.alpha copied to clipboard

Handle non-existent :path

Open SevereOverfl0w opened this issue 2 years ago • 0 comments

See https://github.com/juxt/pack.alpha/discussions/109

https://github.com/juxt/pack.alpha/blob/47ee078edcd6f85353dc5455dc0232c64a46e2ef/src/juxt/pack/jib.clj#L114 is the likely culprit.

The question is, what should be done? Presumably the Clojure CLI ignores this, and we should do the same.

We may want to move the exists check into :builder to match the exact behaviour of the CLI (I'm making assumptions here about what the CLI ends up doing!)

:builder (if (Files/exists ...) (.addEntryRecursive builder ...) builder)

SevereOverfl0w avatar May 26 '22 22:05 SevereOverfl0w