aero icon indicating copy to clipboard operation
aero copied to clipboard

added #int reader

Open source-c opened this issue 4 years ago • 5 comments

for native Java services there are a lot of cases when numeric have to be strictly passed as integer. to avoid manual handling such needs #int reader to be added.

source-c avatar Nov 05 '21 23:11 source-c

Codecov Report

Merging #101 (e13104b) into master (743e9bc) will increase coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   79.13%   79.24%   +0.11%     
==========================================
  Files           4        4              
  Lines         369      371       +2     
  Branches       17       17              
==========================================
+ Hits          292      294       +2     
  Misses         60       60              
  Partials       17       17              
Impacted Files Coverage Δ
src/aero/core.cljc 74.68% <100.00%> (+0.21%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 743e9bc...e13104b. Read the comment docs.

codecov-commenter avatar Nov 05 '21 23:11 codecov-commenter

Any chance this can be merged ? just hit this myself configuring a db pool

DB_POOL_MAX_SIZE is read as a string but not accepted by https://github.com/brettwooldridge/HikariCP

:pool-opts {:maximumPoolSize #or [#env "DB_POOL_MAX_SIZE" 3]}

olymk2 avatar Dec 13 '21 15:12 olymk2

Hello. Is there a chance the request become merged?

source-c avatar May 13 '22 20:05 source-c

Any chance this can be merged ? just hit this myself configuring a db pool

DB_POOL_MAX_SIZE is read as a string but not accepted by https://github.com/brettwooldridge/HikariCP

:pool-opts {:maximumPoolSize #or [#env "DB_POOL_MAX_SIZE" 3]}

You are welcome to use https://github.com/dkdhub/edn-config instead. It is a drop-in replacement with #int reader enabled out-of-the-box.

source-c avatar Sep 20 '22 13:09 source-c