aspnetcore-security-headers icon indicating copy to clipboard operation
aspnetcore-security-headers copied to clipboard

asp.net core 2.1 UseHsts() naming conflict

Open dotnetshadow opened this issue 6 years ago • 3 comments

Hi there,

Great library, I noticed with asp.net core 2.1 that when I'm using your library that I need to fully qualify the name .UseHsts() method that asp.net core 2.1 uses

HstsBuilderExtensions.UseHsts(app);

I can't use

app.UseHsts();

Also I ran your sample app under tests, but I can't seem to see x-frame-options header when I run the app? I see it's using the appsettings config method ( which I can't find documentation on)

dotnetshadow avatar May 11 '18 01:05 dotnetshadow

+1

therawk avatar May 29 '18 16:05 therawk

Great minds think alike etc :smiley: I could rename to like UseStrictTransportSecurity(), but it'd be a breaking change :(

juunas11 avatar May 31 '18 05:05 juunas11

Yes. Even though it's a breaking change I think it should be renamed.

aerichmond avatar Jul 20 '20 17:07 aerichmond