github-release-plugin icon indicating copy to clipboard operation
github-release-plugin copied to clipboard

Published 20 hours ago • verified publisher icon jutzig

this fixes issue#6

Open emmanuelmathot opened this issue 11 years ago • 1 comments
trafficstars

It fixes #6 This is not the most elegant solution but at least it checks the hostname

Signed-off-by: Emmanuel Mathot [email protected]

emmanuelmathot avatar Nov 07 '14 10:11 emmanuelmathot

Thanks for the patch, but I don't want to merge it like that, because that would be a security issue... It seems that the certificate on uploads.github.com is valid for *.githubusercontent.com. Did you get that same certificate as well? IMO there's two possible reasons. Either it's an issue on github side, or they changed the upload URL in which case we should fix the github java API

jutzig avatar Nov 10 '14 15:11 jutzig