github-releases-notifier icon indicating copy to clipboard operation
github-releases-notifier copied to clipboard

#add tagnotify

Open glukaza opened this issue 5 years ago • 4 comments

Notification about new not release tags (some repositories doesn't use "releases")

glukaza avatar Sep 28 '18 11:09 glukaza

Thanks you for sending this PR. Something like that would really be helpful.

Please note, that the current state of this project only saves its state in memory and I (personally) would like to avoid having Redis as dependency. I don't see a problem why the new functionality shouldn't be possible without Redis.

Please also run go fmt on all modified files.

Thanks!

metalmatze avatar Sep 28 '18 13:09 metalmatze

Thakyou for feedback! Entity Tag in github doesn't have field "date" or other fields by which we can make out new release because we need save state, it is bad of course. If I save state in memory, after next restart we will get notifies about all repositories.

glukaza avatar Sep 28 '18 13:09 glukaza

Yup. I think it's exactly the same with the current implementation for official github releases. We simply get everything the first time and only then start notifying if something changes (but it's been a while and I might have to look at the code again).

metalmatze avatar Sep 28 '18 13:09 metalmatze

In case with "Releases" you work with publish_at field but entity tag dosent have it, for example: https://api.github.com/repos/keycloak/keycloak/tags

I can change redis for something other, but without state behavior will be strange

glukaza avatar Sep 28 '18 14:09 glukaza