github-releases-notifier icon indicating copy to clipboard operation
github-releases-notifier copied to clipboard

Provide armv6 docker image

Open pcarranza opened this issue 6 years ago • 8 comments

So this can be executed on a RPI or a pi k8s cluster

pcarranza avatar Jan 27 '18 11:01 pcarranza

I've never built anything but amd64/linux docker images. We may look into this in the future ...

dominikschulz avatar Jan 28 '18 19:01 dominikschulz

I have an image built locally, I can send you a PR to check it out, it's a bit messy but can be useful as a sample.

Still, for releasing purposes and such, have you considered using goreleaser?

pcarranza avatar Jan 28 '18 19:01 pcarranza

Nice! Yes, goreleaser is pretty awesome. I would be fine with using it. :blush:

metalmatze avatar Jan 28 '18 20:01 metalmatze

Any progress on using goreleaser? docker feels overkill for a go library imho 😅 If help wanted also applies to it; maybe it should be a separate issue // title should be renamed?

jlsjonas avatar Oct 03 '18 14:10 jlsjonas

I completely forgot about this, gimme 5m

pcarranza avatar Oct 04 '18 20:10 pcarranza

Here you are https://github.com/justwatchcom/github-releases-notifier/pull/9

I've been running this in a k8s since.... months ago... I just forgot about it because it's been quite stable 😂

pcarranza avatar Oct 04 '18 21:10 pcarranza

Looks like there's a hard limitation in Travis: https://github.com/justwatchcom/github-releases-notifier/pull/9#issuecomment-427505686

WDYT makes sense? I could just skip the whole building docker images to move forward.

pcarranza avatar Oct 05 '18 21:10 pcarranza

Well, there you go.

I removed snapshotting with goreleaser in the CI run because it fails to run in travis, so it goes back to run everything vetting, checks, etc, then build with go, but there's 2 more actions in the makefile: snapshot and release.

So, to release you should just tag with something semver correct, and then just run make release

pcarranza avatar Oct 07 '18 09:10 pcarranza